closer git integration/pr viewer #63

New issue

Closed

opened 2026-04-06 16:25:46 +00:00 by barrettruth · 1 comment

barrettruth commented

2026-04-06 16:25:46 +00:00

Summary

forge.nvim should treat local PR review as a first-class workflow, not as a thin PR-side diff action.

The core idea is:

PR review is the first implementation target
branches / commits / worktrees stay as separate pickers for now
review should still be modeled through a picker-agnostic review API so it can grow cleanly later

Boundary

The top-level :Forge / root + local git picker workflow is tracked separately in #87.

This issue is specifically about the PR review workflow and the review-session engine underneath it.

Design direction

Review should be organized around:

review subject resolution
a first-class review session
a changed-files review index
explicit patch vs file-context views
explicit file and hunk navigation

This keeps the workflow centered on real local review patterns:

choose a PR
start a review session
move through changed files and hunks
open full file context when needed
only materialize workspace state when necessary

Non-goals for this milestone

merging branches/commits/worktrees into the PR review UX
introducing branch/commit review before the PR review model is solid
treating checkout/worktree as the definition of review

Linked issues

#81 Introduce a first-class PR review session model
#82 Rename PR diff actions to review
#83 Add a changed-files review index for PR review
#84 Support patch and file-context views in PR review sessions
#85 Add first-class file and hunk navigation to PR review
#86 Generalize review subjects beyond PRs and support git refs

## Summary forge.nvim should treat local PR review as a first-class workflow, not as a thin PR-side `diff` action. The core idea is: - PR review is the first implementation target - branches / commits / worktrees stay as separate pickers for now - review should still be modeled through a picker-agnostic review API so it can grow cleanly later ## Boundary The top-level `:Forge` / root + local git picker workflow is tracked separately in #87. This issue is specifically about the **PR review workflow** and the review-session engine underneath it. ## Design direction Review should be organized around: - review subject resolution - a first-class review session - a changed-files review index - explicit patch vs file-context views - explicit file and hunk navigation This keeps the workflow centered on real local review patterns: - choose a PR - start a review session - move through changed files and hunks - open full file context when needed - only materialize workspace state when necessary ## Non-goals for this milestone - merging branches/commits/worktrees into the PR review UX - introducing branch/commit review before the PR review model is solid - treating checkout/worktree as the definition of review ## Linked issues - [ ] #81 Introduce a first-class PR review session model - [ ] #82 Rename PR diff actions to review - [ ] #83 Add a changed-files review index for PR review - [ ] #84 Support patch and file-context views in PR review sessions - [ ] #85 Add first-class file and hunk navigation to PR review - [ ] #86 Generalize review subjects beyond PRs and support git refs

barrettruth commented

2026-04-10 22:00:40 +00:00

This umbrella review-workflow issue is now implemented on main through the linked review-session, changed-files, view-mode, and navigation work.