Support patch and file-context views in PR review sessions #84

Closed
opened 2026-04-07 17:04:13 +00:00 by barrettruth · 1 comment
barrettruth commented 2026-04-07 17:04:13 +00:00

Summary

A real local review workflow needs both patch-oriented review and real file-context review. forge already has pieces of this via diffs.nvim and fugitive, but the views are not yet modeled as a coherent review experience.

Goals

  • support patch review and file-context review as explicit modes of a PR review session
  • make switching between them deliberate and consistent
  • preserve the strengths of both: exact diff semantics and surrounding code context

Scope

  • define review view modes for PR review sessions
  • support explicit switching between patch/unified review and file-context/split review
  • clarify how the current file in the review session is carried across mode switches

Out of scope

  • branch/commit review entrypoints
  • changed-files index itself
  • full next/prev file and hunk navigation model

Part of #63.

## Summary A real local review workflow needs both patch-oriented review and real file-context review. forge already has pieces of this via diffs.nvim and fugitive, but the views are not yet modeled as a coherent review experience. ## Goals - support patch review and file-context review as explicit modes of a PR review session - make switching between them deliberate and consistent - preserve the strengths of both: exact diff semantics and surrounding code context ## Scope - define review view modes for PR review sessions - support explicit switching between patch/unified review and file-context/split review - clarify how the current file in the review session is carried across mode switches ## Out of scope - branch/commit review entrypoints - changed-files index itself - full next/prev file and hunk navigation model Part of #63.
barrettruth commented 2026-04-10 22:00:35 +00:00

Implemented on main in #91 with explicit patch and file-context review modes.

Implemented on main in #91 with explicit patch and file-context review modes.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/forge.nvim#84
No description provided.