Generalize review subjects beyond PRs and support git refs #86

Closed
opened 2026-04-07 17:04:16 +00:00 by barrettruth · 1 comment
barrettruth commented 2026-04-07 17:04:16 +00:00

Summary

Once PR review is modeled cleanly, forge can generalize review subjects beyond PRs and eventually support arbitrary git refs. This should stay deferred until the PR review workflow and review session model are solid.

Goals

  • extend review subjects beyond PRs
  • allow branches and commits to launch the same underlying review engine
  • leave room for more general git-ref review later
  • reuse the same session, file index, and navigation model

Candidate subjects

  • branch review against a default-base heuristic
  • commit review against the selected commit's parent
  • later: explicit or arbitrary git-ref/range review where it makes sense

Notes

This is intentionally deferred. PR review should define the workflow first; branch/commit/ref review can follow once the model is proven.

Consolidates #80.
Part of #63.

## Summary Once PR review is modeled cleanly, forge can generalize review subjects beyond PRs and eventually support arbitrary git refs. This should stay deferred until the PR review workflow and review session model are solid. ## Goals - extend review subjects beyond PRs - allow branches and commits to launch the same underlying review engine - leave room for more general git-ref review later - reuse the same session, file index, and navigation model ## Candidate subjects - branch review against a default-base heuristic - commit review against the selected commit's parent - later: explicit or arbitrary git-ref/range review where it makes sense ## Notes This is intentionally deferred. PR review should define the workflow first; branch/commit/ref review can follow once the model is proven. Consolidates #80. Part of #63.
barrettruth commented 2026-04-10 22:00:38 +00:00

Implemented on main in #93 with generalized review subjects beyond pull requests.

Implemented on main in #93 with generalized review subjects beyond pull requests.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/forge.nvim#86
No description provided.