fix(ci): gate deploy on quality jobs #153

Merged
barrettruth merged 1 commit from ci/gate-deploy-on-quality into main 2026-05-03 14:57:48 +00:00
Owner

Problem

The standalone deploy workflow could race the separate quality workflow on pushes to main. Moving Deploy into quality fixed ordering but created a blocked quality / Deploy (pull_request) check on PRs.

Solution

Keep quality PR-only with Format, Lint, and Test. Make deploy a main/manual workflow that runs its own Format, Lint, and Test jobs first, then runs Deploy with needs: [format, lint, test] so production deployment waits for main CI success without creating any Deploy check on PR branches.

## Problem The standalone `deploy` workflow could race the separate `quality` workflow on pushes to `main`. Moving Deploy into `quality` fixed ordering but created a blocked `quality / Deploy (pull_request)` check on PRs. ## Solution Keep `quality` PR-only with Format, Lint, and Test. Make `deploy` a main/manual workflow that runs its own Format, Lint, and Test jobs first, then runs Deploy with `needs: [format, lint, test]` so production deployment waits for main CI success without creating any Deploy check on PR branches.
fix(ci): gate deploy on quality jobs
Some checks failed
quality / Format (pull_request) Successful in 16s
quality / Test (pull_request) Successful in 38s
quality / Deploy (pull_request) Has been cancelled
quality / Lint (pull_request) Has been cancelled
803f5cc9f6
barrettruth force-pushed ci/gate-deploy-on-quality from 803f5cc9f6
Some checks failed
quality / Format (pull_request) Successful in 16s
quality / Test (pull_request) Successful in 38s
quality / Deploy (pull_request) Has been cancelled
quality / Lint (pull_request) Has been cancelled
to cb9d03eff6
All checks were successful
quality / Format (pull_request) Successful in 13s
quality / Test (pull_request) Successful in 38s
quality / Lint (pull_request) Successful in 1m2s
2026-05-03 14:56:00 +00:00
Compare
barrettruth deleted branch ci/gate-deploy-on-quality 2026-05-03 14:57:48 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/vimdoc-language-server!153
No description provided.