fix(ci): resolve lua-language-server warnings #32

Merged

barrettruth merged 1 commit from refactor/command-surface into main

2026-03-04 19:28:52 +00:00

barrettruth commented

2026-03-04 19:27:20 +00:00

Problem

`reload_spec.lua` called `io.open()` without nil checks, surfacing `need-check-nil` warnings. Adding `${3rd}/busted` and `${3rd}/luassert` to `workspace.library` caused lua-language-server 3.7.4 to run diagnostics on its own bundled meta files, surfacing pre-existing `cast-local-type` bugs in luassert's annotations.

Solution

Use `assert(io.open(...))` in `reload_spec.lua`. Remove busted/luassert library paths from `.luarc.json` — they only help spec files which CI doesn't type-check. Narrow `scripts/ci.sh` to check `lua/` only, matching what GitHub CI already does.

## Problem \`reload_spec.lua\` called \`io.open()\` without nil checks, surfacing \`need-check-nil\` warnings. Adding \`\${3rd}/busted\` and \`\${3rd}/luassert\` to \`workspace.library\` caused lua-language-server 3.7.4 to run diagnostics on its own bundled meta files, surfacing pre-existing \`cast-local-type\` bugs in luassert's annotations. ## Solution Use \`assert(io.open(...))\` in \`reload_spec.lua\`. Remove busted/luassert library paths from \`.luarc.json\` — they only help spec files which CI doesn't type-check. Narrow \`scripts/ci.sh\` to check \`lua/\` only, matching what GitHub CI already does.