refactor(pickers): extract shared entity picker builder #555

Merged

barrettruth merged 2 commits from refactor/entity-picker-builder-546 into main

2026-04-29 20:19:18 +00:00

barrettruth commented

2026-04-29 20:18:26 +00:00

Problem

lua/forge/picker/pr.lua, lua/forge/picker/issue.lua, and lua/forge/picker/release.lua still repeated the same entity-picker scaffolding for entry building, cached-first streaming, placeholder and load-more rows, and refresh/revalidation.

Solution

Extract a shared forge.picker.entity helper for that list-building and request/update flow, then rewire the PR, issue, and release picker wrappers to supply only their entity-specific formatting, labels, and value/ordinal behavior.

Closes #546

## Problem `lua/forge/picker/pr.lua`, `lua/forge/picker/issue.lua`, and `lua/forge/picker/release.lua` still repeated the same entity-picker scaffolding for entry building, cached-first streaming, placeholder and load-more rows, and refresh/revalidation. ## Solution Extract a shared `forge.picker.entity` helper for that list-building and request/update flow, then rewire the PR, issue, and release picker wrappers to supply only their entity-specific formatting, labels, and value/ordinal behavior. Closes #546