ci: share LuaRocks quality gate #392

Merged

barrettruth merged 1 commit from ci/consolidate-luarocks-workflow into main

2026-05-03 18:25:03 +00:00

barrettruth commented

2026-05-03 18:24:08 +00:00

Owner

Problem

The stable and nightly LuaRocks deploy workflows both carried the same inline quality-gate polling script, making the two files look almost duplicated and increasing the chance that future fixes drift.

The two workflow files should still remain separate because they are event-specific: stable publishes on version tags, nightly publishes on main pushes/manual dispatch. Combining them would likely surface skipped or blocked jobs on the wrong event in Forgejo checks.

Solution

Move the shared quality-gate polling logic to .forgejo/scripts/wait-for-quality.sh and have both workflows call it through nix shell nixpkgs#curl nixpkgs#jq.

Keep the stable workflow rendering as deploy / LuaRocks, and rename the nightly job to Nightly so it renders as deploy / Nightly.

Validation:

bash -n .forgejo/scripts/wait-for-quality.sh
shellcheck .forgejo/scripts/wait-for-quality.sh
parsed all .forgejo/workflows/*.yaml with PyYAML via Nix
git diff --check

## Problem The stable and nightly LuaRocks deploy workflows both carried the same inline quality-gate polling script, making the two files look almost duplicated and increasing the chance that future fixes drift. The two workflow files should still remain separate because they are event-specific: stable publishes on version tags, nightly publishes on main pushes/manual dispatch. Combining them would likely surface skipped or blocked jobs on the wrong event in Forgejo checks. ## Solution Move the shared quality-gate polling logic to `.forgejo/scripts/wait-for-quality.sh` and have both workflows call it through `nix shell nixpkgs#curl nixpkgs#jq`. Keep the stable workflow rendering as `deploy / LuaRocks`, and rename the nightly job to `Nightly` so it renders as `deploy / Nightly`. Validation: - `bash -n .forgejo/scripts/wait-for-quality.sh` - `shellcheck .forgejo/scripts/wait-for-quality.sh` - parsed all `.forgejo/workflows/*.yaml` with PyYAML via Nix - `git diff --check`

barrettruth added 1 commit

2026-05-03 18:24:08 +00:00

ci: share LuaRocks quality gate

quality / Test (pull_request) Successful in 8s

Details

quality / Format (pull_request) Successful in 9s

Details

quality / Lint (pull_request) Successful in 8s

Details

e8f51ee534