refactor: remove trash adapter from core #210
No reviewers
Labels
No labels
autorelease: pending
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
upstream/digest
upstream/pr
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
barrettruth/canola.nvim!210
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refactor/remove-trash"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The trash adapter (~900 lines across freedesktop, mac, and windows implementations) belongs in
canola-collection, not core. Thedelete_to_trashconfig flag in the files adapter couples the files adapter to the trash adapter.Solution
Remove
delete_to_trashconfig,toggle_trashaction,--trashcommand flag,canola-trash://scheme registration, all trash adapter files, trash highlight groups, trash virtual text rendering, andtrash_spec.lua. Trash moves to canola-collection ascanola-trash.