barrett/canola.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

fix(ssh): preserve path separators in scp:// URI construction

Browse source 
Problem: \`url_to_scp\` passes the file path through \`util.url_escape\`,
which encodes \`/\` as \`%2F\`. The resulting scp command uses a URI like
\`scp://host/%2Ftmp%2Ffile\` where percent-encoded slashes are not
treated as path separators, causing scp to fail with a connection
error.

Solution: unescape \`%2F\` back to \`/\` after encoding, so other special
characters (spaces, \`%\`, etc.) remain encoded but path separators are
preserved. The correct absolute-path URI form is \`scp://host//path\`.
This commit is contained in:
Barrett Ruth 2026-03-18 15:38:56 -04:00
parent 499bae1975
commit 017007954d
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/upstream.md
View file

@ -90,7 +90,7 @@ issues against this fork.
| [#486](https://github.com/stevearc/oil.nvim/issues/486) | Directory sizes show misleading 4.1k | fixed ([#87](https://github.com/barrettruth/canola.nvim/pull/87)) |
| [#492](https://github.com/stevearc/oil.nvim/issues/492) | j/k remapping question | not actionable — answered |
| [#507](https://github.com/stevearc/oil.nvim/issues/507) | lacasitos.nvim conflict | not actionable — cross-plugin + Windows-only |
| [#521](https://github.com/stevearc/oil.nvim/issues/521) | oil-ssh connection issues | open |
| [#521](https://github.com/stevearc/oil.nvim/issues/521) | oil-ssh connection issues | fixed ([#178](https://github.com/barrettruth/canola.nvim/pull/178)) |
| [#525](https://github.com/stevearc/oil.nvim/issues/525) | SSH adapter documentation | fixed — expanded `:help oil-adapter-ssh` ([#138](https://github.com/barrettruth/canola.nvim/pull/138)) |
| [#531](https://github.com/stevearc/oil.nvim/issues/531) | Incomplete drive letters | not actionable — Windows-only |
| [#533](https://github.com/stevearc/oil.nvim/issues/533) | `constrain_cursor` bug | not actionable — needs repro |

2
lua/oil/adapters/ssh.lua
View file

@ -97,7 +97,7 @@ local function url_to_scp(url)
table.insert(pieces, string.format(':%d', url.port))
end
table.insert(pieces, '/')
local escaped_path = util.url_escape(url.path)
local escaped_path = util.url_escape(url.path):gsub('%%2F', '/')
table.insert(pieces, escaped_path)
return table.concat(pieces, '')
end