Build failing due to lack of git clone permission #6

Closed
opened 2023-01-07 22:47:03 +00:00 by AnoRebel · 3 comments
AnoRebel commented 2023-01-07 22:47:03 +00:00

Info

  • Operating System: Mint 21.1
  • nvim --version: 0.8.2 and nightly
  • Node package manager: yarn
  • yarn --version: 1.22.19

Configuration

require('import-cost').setup ()
require('nvim-package-manager').setup {
    -- Any special plugin config
    {
        'barrett-ruth/import-cost.nvim',
        build = "sh install.sh yarn",
        config = function()
            require("import-cost").setup()
        end
    }
}

Description

Basically the wix/import-cost clone in the install.sh uses the git protocol(I tried running the script manually) which requires one to have ssh access to git. Using the https protocol would make it it universal. Simply changing that should fix the bug. Unless there is something I am missing or there is a reason for it being specifically git@github.com:wix/import-cost rather than https://github.com/wix/import-cost.git

<!-- Be sure you can affirm the following: --> <!-- 1. import-cost.nvim is up to date --> <!-- 2. I have searched the issue tracker and not found a similar issue --> ### Info - Operating System: **Mint 21.1** - `nvim --version`: **0.8.2 and nightly** - Node package manager: **yarn** - `yarn --version`: **1.22.19** ### Configuration <!-- Replace the below with your import-cost.nvim setup --> ```lua require('import-cost').setup () ``` <!-- Replace the below with your *neovim* package manager setup --> ```lua require('nvim-package-manager').setup { -- Any special plugin config { 'barrett-ruth/import-cost.nvim', build = "sh install.sh yarn", config = function() require("import-cost").setup() end } } ``` </details> ### Description <!-- A clear and concise description of the bug --> Basically the `wix/import-cost` clone in the `install.sh` uses the `git` protocol(I tried running the script manually) which requires one to have `ssh` access to git. Using the `https` protocol would make it it universal. Simply changing that should fix the bug. Unless there is something I am missing or there is a reason for it being specifically `git@github.com:wix/import-cost` rather than `https://github.com/wix/import-cost.git`
barrettruth commented 2023-01-07 22:53:41 +00:00

My SSH bias was showing. Personal question hy aren't you using it on your clones?

Still, fixed it anyway. The install script now defaults to HTTP

My SSH bias was showing. Personal question hy aren't you using it on your clones? Still, fixed it anyway. The install script now defaults to HTTP
AnoRebel commented 2023-01-08 00:05:53 +00:00

Well, I used to, but I lost my PC, so when I got a temporary new one, and also having a work PC, I found it tedious to handle multiple ssh keys. But I guess its just plain procrastination(I keep telling myself I'll switch when I buy my new/desired PC). But I figured this fix would help even for those who want a quick setup in a VM or temporary PC where they don't need to setup SSH for it.

Thanks for the quick fix.

Well, I used to, but I lost my PC, so when I got a temporary new one, and also having a work PC, I found it tedious to handle multiple ssh keys. But I guess its just plain procrastination(I keep telling myself I'll switch when I buy my new/desired PC). But I figured this fix would help even for those who want a quick setup in a VM or temporary PC where they don't need to setup SSH for it. Thanks for the quick fix.
barrettruth commented 2023-01-08 00:16:00 +00:00

Ok. Please continue to report any more problems you have. Thanks

Ok. Please continue to report any more problems you have. Thanks
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/import-cost.nvim#6
No description provided.