refactor(core): replace remaining internal service-locator calls #522

New issue

Closed

opened 2026-04-29 00:31:23 +00:00 by barrettruth · 1 comment

barrettruth commented

2026-04-29 00:31:23 +00:00

After the recent state extraction series, the remaining internal
require('forge') usage is mostly non-state coupling.

Current hotspots include:

lua/forge/context.lua
lua/forge/routes.lua
lua/forge/ops.lua
lua/forge/review.lua
lua/forge/ci_history.lua
lua/forge/log.lua
lua/forge/pr_checks.lua
lua/forge/term.lua
lua/forge/picker/fzf.lua

The common pattern is internal code reaching through the top-level facade
for config(), current_scope(), remote_web_url(), file_loc(), and
similar helpers.

This issue is for moving those callers onto direct module dependencies so
the top-level forge module keeps shrinking toward a real facade.

After the recent state extraction series, the remaining internal `require('forge')` usage is mostly non-state coupling. Current hotspots include: - `lua/forge/context.lua` - `lua/forge/routes.lua` - `lua/forge/ops.lua` - `lua/forge/review.lua` - `lua/forge/ci_history.lua` - `lua/forge/log.lua` - `lua/forge/pr_checks.lua` - `lua/forge/term.lua` - `lua/forge/picker/fzf.lua` The common pattern is internal code reaching through the top-level facade for `config()`, `current_scope()`, `remote_web_url()`, `file_loc()`, and similar helpers. This issue is for moving those callers onto direct module dependencies so the top-level `forge` module keeps shrinking toward a real facade.

barrettruth commented

2026-04-29 17:27:49 +00:00

Merged via #534 and now on main.

Merged via #534 and now on `main`.