Stop review worktree creation after PR fetch failure #434
Labels
No labels
bug
documentation
duplicate
enhancement
fugitive
good first issue
help wanted
invalid
question
v0.1.0
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
barrettruth/forge.nvim#434
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The review
worktreeadapter startsgit worktree addeven if the preceding PR fetch fails. That hides the fetch error and can replace it with a misleading laterworktree failedmessage.Proposed solution
Check the fetch result first, surface the real fetch error, and only run
git worktree addwhen the fetch step succeeds.Notes