Fix commit picker SHA parsing and upstream fallback #165

Closed
opened 2026-04-12 17:22:02 +00:00 by barrettruth · 1 comment
barrettruth commented 2026-04-12 17:22:02 +00:00

Problem

The commit picker has two separate integrity problems.

  1. SHAs after the first row are getting parsed with a leading newline.
    That breaks:

    • show
    • browse
    • yank
  2. When a branch upstream ref is stale or missing, the commit picker can surface a raw git failure instead of falling back cleanly to the local branch.

Expected

  • trim parsed commit fields
  • treat commit rows as canonical clean data
  • fall back to the local branch when the tracked upstream ref is not usable
## Problem The commit picker has two separate integrity problems. 1. SHAs after the first row are getting parsed with a leading newline. That breaks: - show - browse - yank 2. When a branch upstream ref is stale or missing, the commit picker can surface a raw git failure instead of falling back cleanly to the local branch. ## Expected - trim parsed commit fields - treat commit rows as canonical clean data - fall back to the local branch when the tracked upstream ref is not usable
barrettruth commented 2026-04-12 20:56:16 +00:00

Fixed by #179.

The merged commit-picker fix trims parsed commit rows and falls back cleanly to local history when the upstream ref is stale or unusable.

Fixed by `#179`. The merged commit-picker fix trims parsed commit rows and falls back cleanly to local history when the upstream ref is stale or unusable.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/forge.nvim#165
No description provided.