Make PR review fail loudly when materialization fails #163

New issue

Closed

opened 2026-04-12 17:22:00 +00:00 by barrettruth · 1 comment

barrettruth commented

2026-04-12 17:22:00 +00:00

Problem

PR review currently falls back to the current branch when checkout/materialization fails.

That makes the review flow hard to trust, because the UI still opens a review session even when we are not actually reviewing the PR branch.

Expected

If Forge cannot materialize the PR branch, the review flow should either:

fail clearly, or
use an explicit alternate materialization path,

but it should not silently pretend the current branch is good enough.

## Problem PR review currently falls back to the current branch when checkout/materialization fails. That makes the review flow hard to trust, because the UI still opens a review session even when we are not actually reviewing the PR branch. ## Expected If Forge cannot materialize the PR branch, the review flow should either: - fail clearly, or - use an explicit alternate materialization path, but it should not silently pretend the current branch is good enough.

barrettruth commented

2026-04-12 20:56:15 +00:00

Obsolete after #180.

Review mode/materialization was removed from core, so this failure mode no longer exists in the current codebase.

Obsolete after `#180`. Review mode/materialization was removed from core, so this failure mode no longer exists in the current codebase.