barrett/preview.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 5

fix(ci): resolve lua-language-server warnings (#32)

Browse source 
Problem: reload_spec.lua called io.open() without nil checks, causing
need-check-nil warnings. Adding ${3rd}/busted and ${3rd}/luassert to
workspace.library caused lua-language-server 3.7.4 to run diagnostics
on its own bundled meta files, surfacing pre-existing cast-local-type
bugs in luassert's annotations that are not ours to fix.

Solution: use assert(io.open(...)) in reload_spec.lua to satisfy the
nil check. Remove busted/luassert library paths from .luarc.json since
they only benefit spec/ which is not type-checked in CI. Narrow the
lua-language-server check in scripts/ci.sh to lua/ to match CI.
This commit is contained in:
Barrett Ruth 2026-03-04 14:28:52 -05:00 • committed by GitHub
parent 50a21a787d
commit dd27374833
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 8 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/reload_spec.lua
View file

@ -13,13 +13,13 @@ describe('reload', function()
describe('inject', function()
it('injects script before </body>', function()
local path = os.tmpname()
local f = io.open(path, 'w')
local f = assert(io.open(path, 'w'))
f:write('<html><body><p>hello</p></body></html>')
f:close()
reload.inject(path)
local fr = io.open(path, 'r')
local fr = assert(io.open(path, 'r'))
local content = fr:read('*a')
fr:close()
os.remove(path)
@ -33,13 +33,13 @@ describe('reload', function()
it('appends script when no </body>', function()
local path = os.tmpname()
local f = io.open(path, 'w')
local f = assert(io.open(path, 'w'))
f:write('<html><p>hello</p></html>')
f:close()
reload.inject(path)
local fr = io.open(path, 'r')
local fr = assert(io.open(path, 'r'))
local content = fr:read('*a')
fr:close()
os.remove(path)