From bc22350692cbb61cc067b50731ca4aa77d43f033 Mon Sep 17 00:00:00 2001
From: Barrett Ruth <br.barrettruth@gmail.com>
Date: Wed, 4 Mar 2026 13:49:37 -0500
Subject: [PATCH] fix(init): guard against unnamed buffer in public API

Problem: calling compile/toggle/clean/open on an unsaved scratch
buffer passed an empty string as ctx.file, producing nonsensical
output paths like ".pdf" and silently passing empty strings to
compiler binaries.

Solution: add an early return with a WARN notification in compile,
toggle, clean, and open when the buffer has no file name.
---
 lua/preview/init.lua | 16 ++++++++++++
 spec/init_spec.lua   | 58 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)

diff --git a/lua/preview/init.lua b/lua/preview/init.lua
index 421ba65..fd54d71 100644
--- a/lua/preview/init.lua
+++ b/lua/preview/init.lua
@@ -146,6 +146,10 @@ end
 ---@param bufnr? integer
 function M.compile(bufnr)
   bufnr = bufnr or vim.api.nvim_get_current_buf()
+  if vim.api.nvim_buf_get_name(bufnr) == '' then
+    vim.notify('[preview.nvim]: buffer has no file name', vim.log.levels.WARN)
+    return
+  end
   local name = M.resolve_provider(bufnr)
   if not name then
     vim.notify('[preview.nvim]: no provider configured for this filetype', vim.log.levels.WARN)
@@ -165,6 +169,10 @@ end
 ---@param bufnr? integer
 function M.clean(bufnr)
   bufnr = bufnr or vim.api.nvim_get_current_buf()
+  if vim.api.nvim_buf_get_name(bufnr) == '' then
+    vim.notify('[preview.nvim]: buffer has no file name', vim.log.levels.WARN)
+    return
+  end
   local name = M.resolve_provider(bufnr)
   if not name then
     vim.notify('[preview.nvim]: no provider configured for this filetype', vim.log.levels.WARN)
@@ -178,6 +186,10 @@ end
 ---@param bufnr? integer
 function M.toggle(bufnr)
   bufnr = bufnr or vim.api.nvim_get_current_buf()
+  if vim.api.nvim_buf_get_name(bufnr) == '' then
+    vim.notify('[preview.nvim]: buffer has no file name', vim.log.levels.WARN)
+    return
+  end
   local name = M.resolve_provider(bufnr)
   if not name then
     vim.notify('[preview.nvim]: no provider configured for this filetype', vim.log.levels.WARN)
@@ -190,6 +202,10 @@ end
 ---@param bufnr? integer
 function M.open(bufnr)
   bufnr = bufnr or vim.api.nvim_get_current_buf()
+  if vim.api.nvim_buf_get_name(bufnr) == '' then
+    vim.notify('[preview.nvim]: buffer has no file name', vim.log.levels.WARN)
+    return
+  end
   local name = M.resolve_provider(bufnr)
   local open_config = name and config.providers[name] and config.providers[name].open
   if not compiler.open(bufnr, open_config) then
diff --git a/spec/init_spec.lua b/spec/init_spec.lua
index 5c49276..f68438c 100644
--- a/spec/init_spec.lua
+++ b/spec/init_spec.lua
@@ -108,4 +108,62 @@ describe('preview', function()
       helpers.delete_buffer(bufnr)
     end)
   end)
+
+  describe('unnamed buffer guard', function()
+    before_each(function()
+      helpers.reset_config({ typst = true })
+      preview = require('preview')
+    end)
+
+    local function capture_notify(fn)
+      local msg = nil
+      local orig = vim.notify
+      vim.notify = function(m)
+        msg = m
+      end
+      fn()
+      vim.notify = orig
+      return msg
+    end
+
+    it('compile warns on unnamed buffer', function()
+      local bufnr = helpers.create_buffer({}, 'typst')
+      local msg = capture_notify(function()
+        preview.compile(bufnr)
+      end)
+      assert.is_not_nil(msg)
+      assert.is_truthy(msg:find('no file name'))
+      helpers.delete_buffer(bufnr)
+    end)
+
+    it('toggle warns on unnamed buffer', function()
+      local bufnr = helpers.create_buffer({}, 'typst')
+      local msg = capture_notify(function()
+        preview.toggle(bufnr)
+      end)
+      assert.is_not_nil(msg)
+      assert.is_truthy(msg:find('no file name'))
+      helpers.delete_buffer(bufnr)
+    end)
+
+    it('clean warns on unnamed buffer', function()
+      local bufnr = helpers.create_buffer({}, 'typst')
+      local msg = capture_notify(function()
+        preview.clean(bufnr)
+      end)
+      assert.is_not_nil(msg)
+      assert.is_truthy(msg:find('no file name'))
+      helpers.delete_buffer(bufnr)
+    end)
+
+    it('open warns on unnamed buffer', function()
+      local bufnr = helpers.create_buffer({}, 'typst')
+      local msg = capture_notify(function()
+        preview.open(bufnr)
+      end)
+      assert.is_not_nil(msg)
+      assert.is_truthy(msg:find('no file name'))
+      helpers.delete_buffer(bufnr)
+    end)
+  end)
 end)