From 68e2e8223278e27cddfe9c6f0754e7594546e696 Mon Sep 17 00:00:00 2001
From: Barrett Ruth <62671086+barrettruth@users.noreply.github.com>
Date: Wed, 4 Mar 2026 14:57:36 -0500
Subject: [PATCH] fix(presets): add --failure-level ERROR to asciidoctor, add
 clean to typst/pdflatex/tectonic, skip auto-open on one-shot compile (#35)

Problem: asciidoctor exits 0 on errors so error_parser never ran.
typst, pdflatex, and tectonic had no clean subcommand. auto-open
fired on :Preview compile, surprising users who just want a build.

Solution: pass --failure-level ERROR in asciidoctor args. Add clean
commands to typst (rm pdf), pdflatex (rm pdf/aux/log/synctex.gz),
and tectonic (rm pdf). Gate auto-open on not opts.oneshot so it
only fires during toggle/watch mode.
---
 lua/preview/compiler.lua |  2 ++
 lua/preview/presets.lua  | 12 +++++++++++-
 spec/presets_spec.lua    | 22 +++++++++++++++++-----
 3 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/lua/preview/compiler.lua b/lua/preview/compiler.lua
index 74d6070..38a048e 100644
--- a/lua/preview/compiler.lua
+++ b/lua/preview/compiler.lua
@@ -162,6 +162,7 @@ function M.compile(bufnr, name, provider, ctx, opts)
 
     if
       provider.open
+      and not opts.oneshot
       and not opened[bufnr]
       and output_file ~= ''
       and vim.uv.fs_stat(output_file)
@@ -240,6 +241,7 @@ function M.compile(bufnr, name, provider, ctx, opts)
         end
         if
           provider.open
+          and not opts.oneshot
           and not opened[bufnr]
           and output_file ~= ''
           and vim.uv.fs_stat(output_file)
diff --git a/lua/preview/presets.lua b/lua/preview/presets.lua
index 8a23766..f189e98 100644
--- a/lua/preview/presets.lua
+++ b/lua/preview/presets.lua
@@ -128,6 +128,9 @@ M.typst = {
   error_parser = function(output)
     return parse_typst(output)
   end,
+  clean = function(ctx)
+    return { 'rm', '-f', (ctx.file:gsub('%.typ$', '.pdf')) }
+  end,
   open = true,
   reload = function(ctx)
     return { 'typst', 'watch', ctx.file }
@@ -172,6 +175,10 @@ M.pdflatex = {
   error_parser = function(output)
     return parse_latexmk(output)
   end,
+  clean = function(ctx)
+    local base = ctx.file:gsub('%.tex$', '')
+    return { 'rm', '-f', base .. '.pdf', base .. '.aux', base .. '.log', base .. '.synctex.gz' }
+  end,
   open = true,
 }
 
@@ -188,6 +195,9 @@ M.tectonic = {
   error_parser = function(output)
     return parse_latexmk(output)
   end,
+  clean = function(ctx)
+    return { 'rm', '-f', (ctx.file:gsub('%.tex$', '.pdf')) }
+  end,
   open = true,
 }
 
@@ -246,7 +256,7 @@ M.asciidoctor = {
   ft = 'asciidoc',
   cmd = { 'asciidoctor' },
   args = function(ctx)
-    return { ctx.file, '-o', ctx.output }
+    return { '--failure-level', 'ERROR', ctx.file, '-o', ctx.output }
   end,
   output = function(ctx)
     return (ctx.file:gsub('%.adoc$', '.html'))
diff --git a/spec/presets_spec.lua b/spec/presets_spec.lua
index ab030f0..2a63d18 100644
--- a/spec/presets_spec.lua
+++ b/spec/presets_spec.lua
@@ -33,6 +33,10 @@ describe('presets', function()
       assert.are.equal('/tmp/document.pdf', output)
     end)
 
+    it('returns clean command', function()
+      assert.are.same({ 'rm', '-f', '/tmp/document.pdf' }, presets.typst.clean(ctx))
+    end)
+
     it('has open enabled', function()
       assert.is_true(presets.typst.open)
     end)
@@ -189,8 +193,16 @@ describe('presets', function()
       assert.is_true(presets.pdflatex.open)
     end)
 
-    it('has no clean command', function()
-      assert.is_nil(presets.pdflatex.clean)
+    it('returns clean command removing pdf and aux files', function()
+      local clean = presets.pdflatex.clean(tex_ctx)
+      assert.are.same({
+        'rm',
+        '-f',
+        '/tmp/document.pdf',
+        '/tmp/document.aux',
+        '/tmp/document.log',
+        '/tmp/document.synctex.gz',
+      }, clean)
     end)
 
     it('has no reload', function()
@@ -240,8 +252,8 @@ describe('presets', function()
       assert.is_true(presets.tectonic.open)
     end)
 
-    it('has no clean command', function()
-      assert.is_nil(presets.tectonic.clean)
+    it('returns clean command removing pdf', function()
+      assert.are.same({ 'rm', '-f', '/tmp/document.pdf' }, presets.tectonic.clean(tex_ctx))
     end)
 
     it('has no reload', function()
@@ -467,7 +479,7 @@ describe('presets', function()
 
     it('returns args with file and output', function()
       assert.are.same(
-        { '/tmp/document.adoc', '-o', '/tmp/document.html' },
+        { '--failure-level', 'ERROR', '/tmp/document.adoc', '-o', '/tmp/document.html' },
         presets.asciidoctor.args(adoc_ctx)
       )
     end)