barrett/pending.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix(views): pluralize unknown queue sort key warning

Browse source 
Problem: multiple unknown sort keys each triggered a separate warning.

Solution: collect unknown keys and emit a single warning with the
correct singular/plural label, joined by `, `.
This commit is contained in:
Barrett Ruth 2026-03-12 20:46:36 -04:00
parent 5ab0aa78a1
commit ddf1af79da
Signed by: barrett
GPG key ID: A6C96C9349D2FC81
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lua/pending/views.lua
View file

@ -161,14 +161,19 @@ local function build_queue_comparator()
local log = require('pending.log') local log = require('pending.log')
local keys = config.get().view.queue.sort or { 'status', 'priority', 'due', 'order', 'id' } local keys = config.get().view.queue.sort or { 'status', 'priority', 'due', 'order', 'id' }
local comparators = {} local comparators = {}
local unknown = {}
for _, key in ipairs(keys) do for _, key in ipairs(keys) do
local cmp = sort_key_comparators[key] local cmp = sort_key_comparators[key]
if cmp then if cmp then
table.insert(comparators, cmp) table.insert(comparators, cmp)
else else
log.warn('unknown queue sort key: ' .. key) table.insert(unknown, key)
end end
end end
if #unknown > 0 then
local label = #unknown == 1 and 'unknown queue sort key: ' or 'unknown queue sort keys: '
log.warn(label .. table.concat(unknown, ', '))
end
return function(a, b) return function(a, b)
for _, cmp in ipairs(comparators) do for _, cmp in ipairs(comparators) do
local result = cmp(a, b) local result = cmp(a, b)