diffs.nvim/spec
Barrett Ruth 7106bcc291
refactor(highlight): unified per-line extmark builder (#144)
## Problem

`highlight_hunk` applied DiffsClear extmarks across 5 scattered sites
with
ad-hoc column arithmetic. This fragmentation produced the 1-column
DiffsClear
gap on email-quoted body context lines (#142 issue 1). A redundant
`highlight_hunk_vim_syntax` function duplicated the inline vim syntax
path,
and the deferred pass in init.lua double-called it, creating duplicate
scratch
buffers and extmarks.

## Solution

Reorganize `highlight_hunk` into two clean phases:

- **Phase 1** — multi-line syntax computation (treesitter, vim syntax,
diff
grammar, header context text). Sets syntax extmarks only, no DiffsClear.
- **Phase 2** — per-line chrome (DiffsClear, backgrounds, gutter,
overlays,
  intra-line). All non-syntax extmarks consolidated in one pass.

Hoist `new_code` to function scope (needed by `highlight_text` outside
the
`use_ts` block). Hoist `at_raw_line` so Phase 1d and Phase 2b share one
`nvim_buf_get_lines` call.

Delete `highlight_hunk_vim_syntax` (redundant with inline path). Remove
the
double-call from the deferred pass in init.lua.

Extend body prefix DiffsClear `end_col` from `qw` to `pw + qw`, fixing
the
1-column gap where native treesitter background bled through on context
lines
in email-quoted diffs (#142 issue 1).

### Email-quoted diff support

The parser now strips `> ` (and `>> `, etc.) email quote prefixes before
pattern matching, enabling syntax highlighting for diffs embedded in
email
replies and `git-send-email` / sourcehut-style patch review threads.
Each hunk stores `quote_width` so the highlight pipeline can apply
`DiffsClear` at the correct column offsets to suppress native treesitter
on quoted regions.

Closes #141

### #142 status after this PR

| Sub-issue | Status |
|-----------|--------|
| 1. Col gap on context lines | Fixed |
| 2. Bare `>` context lines | Improved, edge case remains |
| 3. Diff prefix marker fg | Not addressed (follow-up) |
2026-03-05 09:01:22 -05:00
..
commands_spec.lua feat: unified diff conflict resolution for unmerged files (#99) 2026-02-09 12:21:13 -05:00
conflict_spec.lua fix(conflict)!: change default nav keymaps from ]x/[x to ]c/[c (#132) 2026-02-24 12:07:54 -05:00
decoration_provider_spec.lua fix: clear stale gutter extmarks after fugitive section toggle (#139) 2026-02-25 13:20:59 -05:00
diff_spec.lua feat(config): replace algorithm 'auto'/'native' with 'default'/'vscode' 2026-02-06 21:23:40 -05:00
fugitive_spec.lua fix: pre-release cleanup for v0.2.0 (#102) 2026-02-09 15:08:36 -05:00
git_spec.lua feat: add :Gdiff, :Gvdiff, :Ghdiff commands for unified diff view 2026-02-04 19:52:17 -05:00
helpers.lua fix(highlight): include treesitter injections 2026-02-07 14:26:11 -05:00
highlight_spec.lua refactor(highlight): unified per-line extmark builder (#144) 2026-03-05 09:01:22 -05:00
init_spec.lua feat: remove config deprecation in v0.3.0 (#129) 2026-02-18 13:34:43 -05:00
integration_spec.lua refactor(highlight): unified per-line extmark builder (#144) 2026-03-05 09:01:22 -05:00
merge_spec.lua fix(conflict)!: change default nav keymaps from ]x/[x to ]c/[c (#132) 2026-02-24 12:07:54 -05:00
minimal_init.lua feat(test): testing infrastructure 2026-02-01 23:09:05 -05:00
neogit_integration_spec.lua test: add decoration provider, integration, and neogit spec files (#134) 2026-02-25 11:44:56 -05:00
parser_spec.lua refactor(highlight): unified per-line extmark builder (#144) 2026-03-05 09:01:22 -05:00
read_buffer_spec.lua fix(commands): handle :e on diffs:// buffers via BufReadCmd 2026-02-06 22:21:33 -05:00
ux_spec.lua fix(commands): add diff buffer UX improvements 2026-02-07 16:48:31 -05:00