barrett/cp.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 13

fix(credentials): pack CSES token into single credential entry

Browse source 
Problem: the CSES API token was stored as a separate git credential
entry using `path=api-token`, but many credential helpers (e.g.
`cache`) ignore the `path` field, so the token was lost on
retrieval. The scraper `on_event` callback also called
`git_credential.store` from a `uv.spawn` fast event context,
causing `vim.wait` errors.

Solution: encode the CSES token into the password field as
`password<TAB>token` and decode on retrieval. One credential
entry per platform, no `path` dependency. Wrap `store` calls in
`scraper.lua` with `vim.schedule` to avoid fast event context.
This commit is contained in:
Barrett Ruth 2026-03-07 20:04:28 -05:00
parent 0d06d5cb89
commit a255fa47a0
Signed by: barrett
GPG key ID: A6C96C9349D2FC81
2 changed files with 40 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

61
lua/cp/git_credential.lua
View file

@ -57,6 +57,32 @@ local function _parse_output(stdout)
return result
end
local CSES_TOKEN_SEP = '\t'
---@param platform string
---@param password string
---@return string, string?
local function _decode_password(platform, password)
if platform ~= 'cses' then
return password, nil
end
local pw, token = password:match('^(.-)' .. CSES_TOKEN_SEP .. '(.+)$')
if pw then
return pw, token
end
return password, nil
end
---@param password string
---@param token? string
---@return string
local function _encode_password(password, token)
if token then
return password .. CSES_TOKEN_SEP .. token
end
return password
end
---@param platform string
---@return cp.Credentials?
function M.get(platform)
@ -78,19 +104,10 @@ function M.get(platform)
return nil
end
local creds = { username = parsed.username, password = parsed.password }
if platform == 'cses' then
local token_input = _build_input(host, { path = 'api-token' })
local token_obj = vim
.system({ 'git', 'credential', 'fill' }, { stdin = token_input, text = true, timeout = 5000 })
:wait()
if token_obj.code == 0 then
local token_parsed = _parse_output(token_obj.stdout or '')
if token_parsed.password then
creds.token = token_parsed.password
end
end
local password, token = _decode_password(platform, parsed.password)
local creds = { username = parsed.username, password = password }
if token then
creds.token = token
end
return creds
@ -104,14 +121,9 @@ function M.store(platform, creds)
return
end
local input = _build_input(host, { username = creds.username, password = creds.password })
local stored_password = _encode_password(creds.password, creds.token)
local input = _build_input(host, { username = creds.username, password = stored_password })
vim.system({ 'git', 'credential', 'approve' }, { stdin = input, text = true }):wait()
if platform == 'cses' and creds.token then
local token_input =
_build_input(host, { path = 'api-token', username = creds.username, password = creds.token })
vim.system({ 'git', 'credential', 'approve' }, { stdin = token_input, text = true }):wait()
end
end
---@param platform string
@ -122,14 +134,9 @@ function M.reject(platform, creds)
return
end
local input = _build_input(host, { username = creds.username, password = creds.password })
local stored_password = _encode_password(creds.password, creds.token)
local input = _build_input(host, { username = creds.username, password = stored_password })
vim.system({ 'git', 'credential', 'reject' }, { stdin = input, text = true }):wait()
if platform == 'cses' and creds.token then
local token_input =
_build_input(host, { path = 'api-token', username = creds.username, password = creds.token })
vim.system({ 'git', 'credential', 'reject' }, { stdin = token_input, text = true }):wait()
end
end
return M