barrett/cp.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: rename epsilon to precision in runner

Browse source 
Problem: the tolerance field for floating-point comparison was named
`epsilon`, which is an implementation detail, not the user-visible concept.

Solution: rename to `precision` in run.lua type annotations, internal
variables, and comparison logic.
This commit is contained in:
Barrett Ruth 2026-03-03 14:51:37 -05:00 • committed by Barrett Ruth
parent dc9cb10f3a
commit 865e3b5928
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
lua/cp/runner/run.lua
View file

@ -19,7 +19,7 @@
---@class ProblemConstraints ---@class ProblemConstraints
---@field timeout_ms number ---@field timeout_ms number
---@field memory_mb number ---@field memory_mb number
---@field epsilon number? ---@field precision number?
---@class PanelState ---@class PanelState
---@field test_cases RanTestCase[] ---@field test_cases RanTestCase[]
@ -57,8 +57,8 @@ local function load_constraints_from_cache(platform, contest_id, problem_id)
cache.load() cache.load()
local timeout_ms, memory_mb = cache.get_constraints(platform, contest_id, problem_id) local timeout_ms, memory_mb = cache.get_constraints(platform, contest_id, problem_id)
if timeout_ms and memory_mb then if timeout_ms and memory_mb then
local epsilon = cache.get_epsilon(platform, contest_id, problem_id) local precision = cache.get_precision(platform, contest_id, problem_id)
return { timeout_ms = timeout_ms, memory_mb = memory_mb, epsilon = epsilon } return { timeout_ms = timeout_ms, memory_mb = memory_mb, precision = precision }
end end
return nil return nil
end end
@ -103,13 +103,13 @@ end
---@param actual string ---@param actual string
---@param expected string ---@param expected string
---@param epsilon number? ---@param precision number?
---@return boolean ---@return boolean
local function compare_outputs(actual, expected, epsilon) local function compare_outputs(actual, expected, precision)
local norm_actual = normalize_lines(actual) local norm_actual = normalize_lines(actual)
local norm_expected = normalize_lines(expected) local norm_expected = normalize_lines(expected)
if epsilon == nil or epsilon == 0 then if precision == nil or precision == 0 then
return norm_actual == norm_expected return norm_actual == norm_expected
end end
@ -134,7 +134,7 @@ local function compare_outputs(actual, expected, epsilon)
local e_num = tonumber(e_tok) local e_num = tonumber(e_tok)
if a_num ~= nil and e_num ~= nil then if a_num ~= nil and e_num ~= nil then
if math.abs(a_num - e_num) > epsilon then if math.abs(a_num - e_num) > precision then
return false return false
end end
else else
@ -192,9 +192,9 @@ local function run_single_test_case(test_case, debug, on_complete)
end end
local expected = test_case.expected or '' local expected = test_case.expected or ''
local epsilon = (panel_state.constraints and panel_state.constraints.epsilon) local precision = (panel_state.constraints and panel_state.constraints.precision)
or config.ui.panel.epsilon or config.ui.panel.precision
local ok = compare_outputs(out, expected, epsilon) local ok = compare_outputs(out, expected, precision)
local signal = r.signal local signal = r.signal
if not signal and r.code and r.code >= 128 then if not signal and r.code and r.code >= 128 then