barrett/cp.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(scrapers): bad credentials detection and error message cleanup (#367)

Browse source 
## Problem

Wrong credentials produced garbled error messages (`"login failed: Login
failed: bad_credentials"`) and stale credentials remained cached after
failure, causing silent re-use on the next invocation.

## Solution

Standardize all scrapers to emit `"bad_credentials"` as a plain error
code, mapped to a human-readable string via `LOGIN_ERRORS` in
`constants.lua`. Fix `credentials.lua` to clear cached credentials on
failure in both the fresh-prompt and re-prompt paths. For AtCoder and
Codeforces, replace `wait_for_url` with `wait_for_function` to detect
the login error element immediately rather than sitting the full 10s
navigation timeout. Add "Remember me" checkbox on Codeforces login.
This commit is contained in:
Barrett Ruth 2026-03-07 17:58:25 -05:00 • committed by GitHub
parent 573b335646
commit 771dbc7753
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 67 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

26
scrapers/codechef.py
View file

@ -15,7 +15,7 @@ from .base import (
load_platform_cookies,
save_platform_cookies,
)
from .timeouts import BROWSER_SESSION_TIMEOUT, HTTP_TIMEOUT
from .timeouts import BROWSER_NAV_TIMEOUT, BROWSER_SESSION_TIMEOUT, HTTP_TIMEOUT
from .models import (
ContestListResult,
ContestSummary,
@ -84,10 +84,12 @@ def _login_headless_codechef(credentials: dict[str, str]) -> LoginResult:
page.locator('input[name="name"]').fill(credentials.get("username", ""))
page.locator('input[name="pass"]').fill(credentials.get("password", ""))
page.locator("input.cc-login-btn").click()
try:
page.wait_for_url(lambda url: "/login" not in url, timeout=3000)
except Exception:
login_error = "bad credentials?"
page.wait_for_function(
"() => !window.location.href.includes('/login') || !!document.querySelector('div.error')",
timeout=BROWSER_NAV_TIMEOUT,
)
if "/login" in page.url:
login_error = "bad_credentials"
return
except Exception as e:
login_error = str(e)
@ -105,9 +107,7 @@ def _login_headless_codechef(credentials: dict[str, str]) -> LoginResult:
session.fetch(f"{BASE_URL}/", page_action=check_login, network_idle=True)
if not logged_in:
return LoginResult(
success=False, error="Login failed (bad credentials?)"
)
return LoginResult(success=False, error="bad_credentials")
try:
browser_cookies = session.context.cookies()
@ -163,10 +163,12 @@ def _submit_headless_codechef(
page.locator('input[name="name"]').fill(credentials.get("username", ""))
page.locator('input[name="pass"]').fill(credentials.get("password", ""))
page.locator("input.cc-login-btn").click()
try:
page.wait_for_url(lambda url: "/login" not in url, timeout=3000)
except Exception:
login_error = "bad credentials?"
page.wait_for_function(
"() => !window.location.href.includes('/login') || !!document.querySelector('div.error')",
timeout=BROWSER_NAV_TIMEOUT,
)
if "/login" in page.url:
login_error = "bad_credentials"
return
except Exception as e:
login_error = str(e)