barrett/cp.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(scrapers): bad credentials detection and error message cleanup (#367)

Browse source 
## Problem

Wrong credentials produced garbled error messages (`"login failed: Login
failed: bad_credentials"`) and stale credentials remained cached after
failure, causing silent re-use on the next invocation.

## Solution

Standardize all scrapers to emit `"bad_credentials"` as a plain error
code, mapped to a human-readable string via `LOGIN_ERRORS` in
`constants.lua`. Fix `credentials.lua` to clear cached credentials on
failure in both the fresh-prompt and re-prompt paths. For AtCoder and
Codeforces, replace `wait_for_url` with `wait_for_function` to detect
the login error element immediately rather than sitting the full 10s
navigation timeout. Add "Remember me" checkbox on Codeforces login.
This commit is contained in:
Barrett Ruth 2026-03-07 17:58:25 -05:00 • committed by GitHub
parent 573b335646
commit 771dbc7753
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 67 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

20
scrapers/atcoder.py
View file

@ -400,9 +400,13 @@ def _at_login_action(credentials: dict[str, str]):
page.fill('input[name="username"]', credentials.get("username", ""))
page.fill('input[name="password"]', credentials.get("password", ""))
page.click("#submit")
page.wait_for_url(
lambda url: "/login" not in url, timeout=BROWSER_NAV_TIMEOUT
page.wait_for_function(
"() => !window.location.href.includes('/login') || !!document.querySelector('.alert-danger')",
timeout=BROWSER_NAV_TIMEOUT,
)
if "/login" in page.url:
login_error = "bad_credentials"
return
except Exception as e:
login_error = str(e)
@ -460,7 +464,9 @@ def _login_headless(credentials: dict[str, str]) -> LoginResult:
solve_cloudflare=True,
)
login_error = get_error()
if login_error:
if login_error == "bad_credentials":
return LoginResult(success=False, error="bad_credentials")
elif login_error:
return LoginResult(success=False, error=f"Login failed: {login_error}")
logged_in = False
@ -473,9 +479,7 @@ def _login_headless(credentials: dict[str, str]) -> LoginResult:
f"{BASE_URL}/home", page_action=verify_action, network_idle=True
)
if not logged_in:
return LoginResult(
success=False, error="Login failed (bad credentials?)"
)
return LoginResult(success=False, error="bad_credentials")
try:
browser_cookies = session.context.cookies()
@ -570,7 +574,9 @@ def _submit_headless(
solve_cloudflare=True,
)
login_error = get_login_error()
if login_error:
if login_error == "bad_credentials":
return SubmitResult(success=False, error="bad_credentials")
elif login_error:
return SubmitResult(
success=False, error=f"Login failed: {login_error}"
)