refactor: remove open_url config option in favour of :CP open (#322)
## Problem `open_url` automatically opened the browser on contest load and problem change, which is now redundant with `:CP open`. ## Solution Remove the `open_url` field from `cp.Config`, its default, its validation, and the call site in `setup_contest`. Remove documentation from `cp.nvim.txt`.
This commit is contained in:
parent
401afb205e
commit
2d50f0a52a
3 changed files with 0 additions and 14 deletions
|
|
@ -101,7 +101,6 @@
|
|||
---@field templates? CpTemplatesConfig
|
||||
---@field hooks Hooks
|
||||
---@field debug boolean
|
||||
---@field open_url boolean
|
||||
---@field scrapers string[]
|
||||
---@field filename? fun(contest: string, contest_id: string, problem_id?: string, config: cp.Config, language?: string): string
|
||||
---@field ui CpUI
|
||||
|
|
@ -118,7 +117,6 @@ local utils = require('cp.utils')
|
|||
-- defaults per the new single schema
|
||||
---@type cp.Config
|
||||
M.defaults = {
|
||||
open_url = false,
|
||||
languages = {
|
||||
cpp = {
|
||||
extension = 'cc',
|
||||
|
|
@ -362,7 +360,6 @@ function M.setup(user_config)
|
|||
hooks = { cfg.hooks, { 'table' } },
|
||||
ui = { cfg.ui, { 'table' } },
|
||||
debug = { cfg.debug, { 'boolean', 'nil' }, true },
|
||||
open_url = { cfg.open_url, { 'boolean', 'nil' }, true },
|
||||
filename = { cfg.filename, { 'function', 'nil' }, true },
|
||||
scrapers = {
|
||||
cfg.scrapers,
|
||||
|
|
|
|||
|
|
@ -164,7 +164,6 @@ end
|
|||
---@param language? string
|
||||
function M.setup_contest(platform, contest_id, problem_id, language)
|
||||
local old_platform, old_contest_id = state.get_platform(), state.get_contest_id()
|
||||
local old_problem_id = state.get_problem_id()
|
||||
|
||||
state.set_platform(platform)
|
||||
state.set_contest_id(contest_id)
|
||||
|
|
@ -205,13 +204,6 @@ function M.setup_contest(platform, contest_id, problem_id, language)
|
|||
local pid = problem_id and problem_id or problems[1].id
|
||||
M.setup_problem(pid, language)
|
||||
start_tests(platform, contest_id, problems)
|
||||
|
||||
local is_new_problem = old_problem_id ~= pid
|
||||
local should_open_url = config_module.get_config().open_url
|
||||
and (is_new_contest or is_new_problem)
|
||||
if should_open_url and contest_data.url then
|
||||
vim.ui.open(contest_data.url:format(pid))
|
||||
end
|
||||
end
|
||||
|
||||
local contest_data = cache.get_contest_data(platform, contest_id)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue