* build: replace luacheck with selene Problem: luacheck is unmaintained (last release 2018) and required suppressing four warning classes to avoid false positives. It also lacks first-class vim/neovim awareness. Solution: switch to selene with std='vim' for vim-aware linting. Replace the luacheck CI job with selene, update the Makefile lint target, and delete .luacheckrc. * build: add nix devshell and pre-commit hooks Problem: oil.nvim had no reproducible dev environment. The .envrc set up a Python venv for the now-removed docgen pipeline, and there were no pre-commit hooks for local formatting checks. Solution: add flake.nix with stylua, selene, and prettier in the devshell. Replace the stale Python .envrc with 'use flake'. Add .pre-commit-config.yaml with stylua and prettier hooks matching other plugins in the repo collection. * fix: format with stylua * build(selene): configure lints and add inline suppressions Problem: selene fails on 5 errors and 3 warnings from upstream code patterns that are intentional (mixed tables in config API, unused callback parameters, identical if branches for readability). Solution: globally allow mixed_table and unused_variable (high volume, inherent to the codebase design). Add inline selene:allow directives for the 8 remaining issues: if_same_then_else (4), mismatched_arg_count (1), empty_if (2), global_usage (1). Remove .envrc from tracking. * build: switch typecheck action to mrcjkb/lua-typecheck-action Problem: oil.nvim used stevearc/nvim-typecheck-action, which required cloning the action repo locally for the Makefile lint target. All other plugins in the collection use mrcjkb/lua-typecheck-action. Solution: swap to mrcjkb/lua-typecheck-action@v0 for consistency. Remove the nvim-typecheck-action git clone from the Makefile and .gitignore. Drop LuaLS from the local lint target since it requires a full language server install — CI handles it.
150 lines
5.1 KiB
Lua
150 lines
5.1 KiB
Lua
require('plenary.async').tests.add_to_env()
|
|
local TmpDir = require('tests.tmpdir')
|
|
local test_util = require('tests.test_util')
|
|
|
|
a.describe('freedesktop', function()
|
|
local tmpdir
|
|
local tmphome
|
|
local home = vim.env.XDG_DATA_HOME
|
|
a.before_each(function()
|
|
require('oil.config').delete_to_trash = true
|
|
tmpdir = TmpDir.new()
|
|
tmphome = TmpDir.new()
|
|
package.loaded['oil.adapters.trash'] = require('oil.adapters.trash.freedesktop')
|
|
vim.env.XDG_DATA_HOME = tmphome.path
|
|
end)
|
|
a.after_each(function()
|
|
vim.env.XDG_DATA_HOME = home
|
|
if tmpdir then
|
|
tmpdir:dispose()
|
|
end
|
|
if tmphome then
|
|
tmphome:dispose()
|
|
end
|
|
test_util.reset_editor()
|
|
package.loaded['oil.adapters.trash'] = nil
|
|
end)
|
|
|
|
a.it('files can be moved to the trash', function()
|
|
tmpdir:create({ 'a.txt', 'foo/b.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
vim.api.nvim_feedkeys('p', 'x', true)
|
|
test_util.actions.save()
|
|
tmpdir:assert_not_exists('a.txt')
|
|
tmpdir:assert_exists('foo/b.txt')
|
|
test_util.actions.reload()
|
|
assert.are.same({ 'a.txt' }, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('deleting a file moves it to trash', function()
|
|
tmpdir:create({ 'a.txt', 'foo/b.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
tmpdir:assert_not_exists('a.txt')
|
|
tmpdir:assert_exists('foo/b.txt')
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
assert.are.same({ 'a.txt' }, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('deleting a directory moves it to trash', function()
|
|
tmpdir:create({ 'a.txt', 'foo/b.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('foo/')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
tmpdir:assert_not_exists('foo')
|
|
tmpdir:assert_exists('a.txt')
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
assert.are.same({ 'foo/' }, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('deleting a file from trash deletes it permanently', function()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.reload()
|
|
tmpdir:assert_not_exists('a.txt')
|
|
assert.are.same({}, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('cannot create files in the trash', function()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
vim.api.nvim_feedkeys('onew_file.txt', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.reload()
|
|
assert.are.same({ 'a.txt' }, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('cannot rename files in the trash', function()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
vim.api.nvim_feedkeys('0facwnew_name', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.reload()
|
|
assert.are.same({ 'a.txt' }, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('cannot copy files in the trash', function()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
vim.api.nvim_feedkeys('yypp', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.reload()
|
|
assert.are.same({ 'a.txt' }, test_util.parse_entries(0))
|
|
end)
|
|
|
|
a.it('can restore files from trash', function()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
test_util.actions.focus('a.txt')
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.open({ tmpdir.path })
|
|
vim.api.nvim_feedkeys('p', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.reload()
|
|
assert.are.same({ 'a.txt' }, test_util.parse_entries(0))
|
|
tmpdir:assert_fs({
|
|
['a.txt'] = 'a.txt',
|
|
})
|
|
end)
|
|
|
|
a.it('can have multiple files with the same name in trash', function()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.open({ tmpdir.path })
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
tmpdir:create({ 'a.txt' })
|
|
test_util.actions.reload()
|
|
vim.api.nvim_feedkeys('dd', 'x', true)
|
|
test_util.actions.save()
|
|
test_util.actions.open({ '--trash', tmpdir.path })
|
|
assert.are.same({ 'a.txt', 'a.txt' }, test_util.parse_entries(0))
|
|
end)
|
|
end)
|