* build: replace luacheck with selene Problem: luacheck is unmaintained (last release 2018) and required suppressing four warning classes to avoid false positives. It also lacks first-class vim/neovim awareness. Solution: switch to selene with std='vim' for vim-aware linting. Replace the luacheck CI job with selene, update the Makefile lint target, and delete .luacheckrc. * build: add nix devshell and pre-commit hooks Problem: oil.nvim had no reproducible dev environment. The .envrc set up a Python venv for the now-removed docgen pipeline, and there were no pre-commit hooks for local formatting checks. Solution: add flake.nix with stylua, selene, and prettier in the devshell. Replace the stale Python .envrc with 'use flake'. Add .pre-commit-config.yaml with stylua and prettier hooks matching other plugins in the repo collection. * fix: format with stylua * build(selene): configure lints and add inline suppressions Problem: selene fails on 5 errors and 3 warnings from upstream code patterns that are intentional (mixed tables in config API, unused callback parameters, identical if branches for readability). Solution: globally allow mixed_table and unused_variable (high volume, inherent to the codebase design). Add inline selene:allow directives for the 8 remaining issues: if_same_then_else (4), mismatched_arg_count (1), empty_if (2), global_usage (1). Remove .envrc from tracking. * build: switch typecheck action to mrcjkb/lua-typecheck-action Problem: oil.nvim used stevearc/nvim-typecheck-action, which required cloning the action repo locally for the Makefile lint target. All other plugins in the collection use mrcjkb/lua-typecheck-action. Solution: swap to mrcjkb/lua-typecheck-action@v0 for consistency. Remove the nvim-typecheck-action git clone from the Makefile and .gitignore. Drop LuaLS from the local lint target since it requires a full language server install — CI handles it.
168 lines
4.1 KiB
Lua
168 lines
4.1 KiB
Lua
local fs = require('oil.fs')
|
|
local test_util = require('tests.test_util')
|
|
|
|
local await = test_util.await
|
|
|
|
---@param path string
|
|
---@param cb fun(err: nil|string)
|
|
local function touch(path, cb)
|
|
vim.loop.fs_open(path, 'w', 420, function(err, fd) -- 0644
|
|
if err then
|
|
cb(err)
|
|
else
|
|
local shortpath = path:gsub('^[^' .. fs.sep .. ']*' .. fs.sep, '')
|
|
vim.loop.fs_write(fd, shortpath, nil, function(err2)
|
|
if err2 then
|
|
cb(err2)
|
|
else
|
|
vim.loop.fs_close(fd, cb)
|
|
end
|
|
end)
|
|
end
|
|
end)
|
|
end
|
|
|
|
---@param filepath string
|
|
---@return boolean
|
|
local function exists(filepath)
|
|
local stat = vim.loop.fs_stat(filepath)
|
|
return stat ~= nil and stat.type ~= nil
|
|
end
|
|
local TmpDir = {}
|
|
|
|
TmpDir.new = function()
|
|
local path = await(vim.loop.fs_mkdtemp, 2, 'oil_test_XXXXXXXXX')
|
|
a.util.scheduler()
|
|
return setmetatable({ path = path }, {
|
|
__index = TmpDir,
|
|
})
|
|
end
|
|
|
|
---@param paths string[]
|
|
function TmpDir:create(paths)
|
|
for _, path in ipairs(paths) do
|
|
local pieces = vim.split(path, fs.sep)
|
|
local partial_path = self.path
|
|
for i, piece in ipairs(pieces) do
|
|
partial_path = fs.join(partial_path, piece)
|
|
if i == #pieces and not vim.endswith(partial_path, fs.sep) then
|
|
await(touch, 2, partial_path)
|
|
elseif not exists(partial_path) then
|
|
vim.loop.fs_mkdir(partial_path, 493)
|
|
end
|
|
end
|
|
end
|
|
a.util.scheduler()
|
|
end
|
|
|
|
---@param filepath string
|
|
---@return string?
|
|
local read_file = function(filepath)
|
|
local fd = vim.loop.fs_open(filepath, 'r', 420)
|
|
if not fd then
|
|
return nil
|
|
end
|
|
local stat = vim.loop.fs_fstat(fd)
|
|
local content = vim.loop.fs_read(fd, stat.size)
|
|
vim.loop.fs_close(fd)
|
|
a.util.scheduler()
|
|
return content
|
|
end
|
|
|
|
---@param dir string
|
|
---@param cb fun(err: nil|string, entry: {type: oil.EntryType, name: string, root: string}
|
|
local function walk(dir)
|
|
local ret = {}
|
|
for name, type in vim.fs.dir(dir) do
|
|
table.insert(ret, {
|
|
name = name,
|
|
type = type,
|
|
root = dir,
|
|
})
|
|
if type == 'directory' then
|
|
vim.list_extend(ret, walk(fs.join(dir, name)))
|
|
end
|
|
end
|
|
return ret
|
|
end
|
|
|
|
---@param paths table<string, string>
|
|
local assert_fs = function(root, paths)
|
|
local unlisted_dirs = {}
|
|
for k in pairs(paths) do
|
|
local pieces = vim.split(k, '/')
|
|
local partial_path = ''
|
|
for i, piece in ipairs(pieces) do
|
|
partial_path = partial_path .. piece .. '/'
|
|
if i ~= #pieces then
|
|
unlisted_dirs[partial_path] = true
|
|
end
|
|
end
|
|
end
|
|
for k in pairs(unlisted_dirs) do
|
|
paths[k] = true
|
|
end
|
|
|
|
local entries = walk(root)
|
|
for _, entry in ipairs(entries) do
|
|
local fullpath = fs.join(entry.root, entry.name)
|
|
local shortpath = fullpath:sub(root:len() + 2)
|
|
if entry.type == 'directory' then
|
|
shortpath = shortpath .. '/'
|
|
end
|
|
local expected_content = paths[shortpath]
|
|
paths[shortpath] = nil
|
|
assert.truthy(expected_content, string.format("Unexpected entry '%s'", shortpath))
|
|
if entry.type == 'file' then
|
|
local data = read_file(fullpath)
|
|
assert.equals(
|
|
expected_content,
|
|
data,
|
|
string.format(
|
|
"File '%s' expected content '%s' received '%s'",
|
|
shortpath,
|
|
expected_content,
|
|
data
|
|
)
|
|
)
|
|
end
|
|
end
|
|
|
|
for k, v in pairs(paths) do
|
|
assert.falsy(
|
|
k,
|
|
string.format(
|
|
"Expected %s '%s', but it was not found",
|
|
v == true and 'directory' or 'file',
|
|
k
|
|
)
|
|
)
|
|
end
|
|
end
|
|
|
|
---@param paths table<string, string>
|
|
function TmpDir:assert_fs(paths)
|
|
a.util.scheduler()
|
|
assert_fs(self.path, paths)
|
|
end
|
|
|
|
function TmpDir:assert_exists(path)
|
|
a.util.scheduler()
|
|
path = fs.join(self.path, path)
|
|
local stat = vim.loop.fs_stat(path)
|
|
assert.truthy(stat, string.format("Expected path '%s' to exist", path))
|
|
end
|
|
|
|
function TmpDir:assert_not_exists(path)
|
|
a.util.scheduler()
|
|
path = fs.join(self.path, path)
|
|
local stat = vim.loop.fs_stat(path)
|
|
assert.falsy(stat, string.format("Expected path '%s' to not exist", path))
|
|
end
|
|
|
|
function TmpDir:dispose()
|
|
await(fs.recursive_delete, 3, 'directory', self.path)
|
|
a.util.scheduler()
|
|
end
|
|
|
|
return TmpDir
|