86f553cd0a
* build: replace luacheck with selene Problem: luacheck is unmaintained (last release 2018) and required suppressing four warning classes to avoid false positives. It also lacks first-class vim/neovim awareness. Solution: switch to selene with std='vim' for vim-aware linting. Replace the luacheck CI job with selene, update the Makefile lint target, and delete .luacheckrc. * build: add nix devshell and pre-commit hooks Problem: oil.nvim had no reproducible dev environment. The .envrc set up a Python venv for the now-removed docgen pipeline, and there were no pre-commit hooks for local formatting checks. Solution: add flake.nix with stylua, selene, and prettier in the devshell. Replace the stale Python .envrc with 'use flake'. Add .pre-commit-config.yaml with stylua and prettier hooks matching other plugins in the repo collection. * fix: format with stylua * build(selene): configure lints and add inline suppressions Problem: selene fails on 5 errors and 3 warnings from upstream code patterns that are intentional (mixed tables in config API, unused callback parameters, identical if branches for readability). Solution: globally allow mixed_table and unused_variable (high volume, inherent to the codebase design). Add inline selene:allow directives for the 8 remaining issues: if_same_then_else (4), mismatched_arg_count (1), empty_if (2), global_usage (1). Remove .envrc from tracking. * build: switch typecheck action to mrcjkb/lua-typecheck-action Problem: oil.nvim used stevearc/nvim-typecheck-action, which required cloning the action repo locally for the Makefile lint target. All other plugins in the collection use mrcjkb/lua-typecheck-action. Solution: swap to mrcjkb/lua-typecheck-action@v0 for consistency. Remove the nvim-typecheck-action git clone from the Makefile and .gitignore. Drop LuaLS from the local lint target since it requires a full language server install — CI handles it.
48 lines
1.2 KiB
Lua
48 lines
1.2 KiB
Lua
local M = {}
|
|
|
|
M.run = function(cmd, opts, callback)
|
|
if not callback then
|
|
callback = opts
|
|
opts = {}
|
|
end
|
|
local stdout
|
|
local stderr = {}
|
|
local jid = vim.fn.jobstart(
|
|
cmd,
|
|
vim.tbl_deep_extend('keep', opts, {
|
|
stdout_buffered = true,
|
|
stderr_buffered = true,
|
|
on_stdout = function(j, output)
|
|
stdout = output
|
|
end,
|
|
on_stderr = function(j, output)
|
|
stderr = output
|
|
end,
|
|
on_exit = vim.schedule_wrap(function(j, code)
|
|
if code == 0 then
|
|
callback(nil, stdout)
|
|
else
|
|
local err = table.concat(stderr, '\n')
|
|
if err == '' then
|
|
err = 'Unknown error'
|
|
end
|
|
local cmd_str = type(cmd) == 'string' and cmd or table.concat(cmd, ' ')
|
|
callback(string.format("Error running command '%s'\n%s", cmd_str, err))
|
|
end
|
|
end),
|
|
})
|
|
)
|
|
local exe
|
|
if type(cmd) == 'string' then
|
|
exe = vim.split(cmd, '%s+')[1]
|
|
else
|
|
exe = cmd[1]
|
|
end
|
|
if jid == 0 then
|
|
callback(string.format("Passed invalid arguments to '%s'", exe))
|
|
elseif jid == -1 then
|
|
callback(string.format("'%s' is not executable", exe))
|
|
end
|
|
end
|
|
|
|
return M
|