barrett/canola.nvim
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

fix: propagate errors in recursive_delete and recursive_copy (#712)

Browse source 
The `complete` callback checks `err` instead of `err2`, but `err` is
always nil inside the `elseif entries` branch. This silently ignores
child operation errors, causing misleading "directory not empty" failures.
This commit is contained in:
Sebastian Oberhoff 2026-01-11 22:55:32 +01:00 • committed by GitHub
parent 43227c5a1c
commit d278dc40f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lua/oil/fs.lua
View file

@ -218,7 +218,7 @@ M.recursive_delete = function(entry_type, path, cb)
local waiting = #entries local waiting = #entries
local complete local complete
complete = function(err2) complete = function(err2)
if err then if err2 then
complete = function() end complete = function() end
return inner_cb(err2) return inner_cb(err2)
end end
@ -320,7 +320,7 @@ M.recursive_copy = function(entry_type, src_path, dest_path, cb)
local waiting = #entries local waiting = #entries
local complete local complete
complete = function(err2) complete = function(err2)
if err then if err2 then
complete = function() end complete = function() end
return inner_cb(err2) return inner_cb(err2)
end end