barrett/bmath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

some toods

Browse source
This commit is contained in:
Barrett Ruth 2025-10-05 00:30:49 -04:00
parent d207769de9
commit 2e30696e49
3 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/bmath/mint.hh
View file

@ -51,6 +51,7 @@ class mint {
} }
[[nodiscard]] constexpr mint operator/(mint const other) const noexcept { [[nodiscard]] constexpr mint operator/(mint const other) const noexcept {
// TODO: if consteval
if constexpr (other.get() == 0) { if constexpr (other.get() == 0) {
static_assert(false, "Cannot divide by 0"); static_assert(false, "Cannot divide by 0");
} else if (other.get() == 0) { } else if (other.get() == 0) {
@ -96,6 +97,7 @@ class mint {
return *this; return *this;
} }
// TODO: check this
constexpr mint operator++(int) noexcept { constexpr mint operator++(int) noexcept {
auto _this = *this; auto _this = *this;

1
include/bmath/sieve.hh
View file

@ -40,6 +40,7 @@ class Eratosthenes : public Sieve<Eratosthenes<Limit>, Limit> {
[[nodiscard]] constexpr bool operator[](size_t const number) const { [[nodiscard]] constexpr bool operator[](size_t const number) const {
if consteval { if consteval {
// TODO: does/can this run at compile time?
if (number > Limit) { if (number > Limit) {
throw std::out_of_range( throw std::out_of_range(
std::format("cannot determine primality of {} > size of sieve {}", std::format("cannot determine primality of {} > size of sieve {}",

1
tests/test_sieve.cc
View file

@ -28,6 +28,7 @@ TEST(SieveTest, BasicConstruction) { Eratosthenes<100> sieve; }
TEST(SieveTest, ValidateAgainstNaive) { TEST(SieveTest, ValidateAgainstNaive) {
Eratosthenes<1000> sieve; Eratosthenes<1000> sieve;
// TODO: assert done at compile time
for (size_t i = 0; i <= 1000; ++i) { for (size_t i = 0; i <= 1000; ++i) {
EXPECT_EQ(sieve[i], naive_prime(i)) EXPECT_EQ(sieve[i], naive_prime(i))
<< "Sieve disagrees with naive checker for " << i; << "Sieve disagrees with naive checker for " << i;