perf: async enum file read (#10)
Some checks are pending
quality / changes (push) Waiting to run
quality / Lua Format Check (push) Blocked by required conditions
quality / Lua Lint Check (push) Blocked by required conditions
quality / Lua Type Check (push) Blocked by required conditions
quality / Markdown Format Check (push) Blocked by required conditions
test / Test (Neovim nightly) (push) Waiting to run
test / Test (Neovim stable) (push) Waiting to run
luarocks / quality (push) Waiting to run
luarocks / publish (push) Blocked by required conditions
Some checks are pending
quality / changes (push) Waiting to run
quality / Lua Format Check (push) Blocked by required conditions
quality / Lua Lint Check (push) Blocked by required conditions
quality / Lua Type Check (push) Blocked by required conditions
quality / Markdown Format Check (push) Blocked by required conditions
test / Test (Neovim nightly) (push) Waiting to run
test / Test (Neovim stable) (push) Waiting to run
luarocks / quality (push) Waiting to run
luarocks / publish (push) Blocked by required conditions
* perf: async enum file read Problem: parse_enums read the bash-completion file with blocking io.open/fd:read on the main thread, stalling the event loop. Solution: read the file via vim.uv.fs_open/fstat/read with callbacks, running in parallel with the ghostty config system call using the same remaining-counter pattern as the other blink-cmp plugins. * fix: lint warning and test mocks for async file read Problem: selene flagged unused err3 variable, and test mock_enums still mocked io.open instead of the new vim.uv.fs_* calls. Solution: rename err3 to _, replace io.open mock with synchronous vim.uv.fs_open/fs_fstat/fs_read/fs_close mocks using a sentinel fd.
This commit is contained in:
parent
fe16245881
commit
0b137d64f6
2 changed files with 77 additions and 27 deletions
|
|
@ -55,10 +55,15 @@ local function mock_system()
|
|||
end
|
||||
end
|
||||
|
||||
local MOCK_FD = 99
|
||||
|
||||
local function mock_enums()
|
||||
local original_exepath = vim.fn.exepath
|
||||
local original_realpath = vim.uv.fs_realpath
|
||||
local original_open = io.open
|
||||
local original_fs_open = vim.uv.fs_open
|
||||
local original_fs_fstat = vim.uv.fs_fstat
|
||||
local original_fs_read = vim.uv.fs_read
|
||||
local original_fs_close = vim.uv.fs_close
|
||||
|
||||
vim.fn.exepath = function(name)
|
||||
if name == 'ghostty' then
|
||||
|
|
@ -72,24 +77,41 @@ local function mock_enums()
|
|||
end
|
||||
return original_realpath(path)
|
||||
end
|
||||
-- selene: allow(incorrect_standard_library_use)
|
||||
io.open = function(path, mode)
|
||||
vim.uv.fs_open = function(path, flags, mode, callback)
|
||||
if path:match('ghostty%.bash$') then
|
||||
return {
|
||||
read = function()
|
||||
return BASH_COMPLETION
|
||||
end,
|
||||
close = function() end,
|
||||
}
|
||||
callback(nil, MOCK_FD)
|
||||
return
|
||||
end
|
||||
return original_open(path, mode)
|
||||
return original_fs_open(path, flags, mode, callback)
|
||||
end
|
||||
vim.uv.fs_fstat = function(fd, callback)
|
||||
if fd == MOCK_FD then
|
||||
callback(nil, { size = #BASH_COMPLETION })
|
||||
return
|
||||
end
|
||||
return original_fs_fstat(fd, callback)
|
||||
end
|
||||
vim.uv.fs_read = function(fd, size, offset, callback)
|
||||
if fd == MOCK_FD then
|
||||
callback(nil, BASH_COMPLETION)
|
||||
return
|
||||
end
|
||||
return original_fs_read(fd, size, offset, callback)
|
||||
end
|
||||
vim.uv.fs_close = function(fd, ...)
|
||||
if fd == MOCK_FD then
|
||||
return true
|
||||
end
|
||||
return original_fs_close(fd, ...)
|
||||
end
|
||||
|
||||
return function()
|
||||
vim.fn.exepath = original_exepath
|
||||
vim.uv.fs_realpath = original_realpath
|
||||
-- selene: allow(incorrect_standard_library_use)
|
||||
io.open = original_open
|
||||
vim.uv.fs_open = original_fs_open
|
||||
vim.uv.fs_fstat = original_fs_fstat
|
||||
vim.uv.fs_read = original_fs_read
|
||||
vim.uv.fs_close = original_fs_close
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue